Skip to content

Update performance.rst #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update performance.rst #8332

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b81dca2
Update performance.rst
seferov Sep 1, 2017
0b55792
Update performance.rst
seferov Sep 3, 2017
f28e767
Update performance.rst
seferov Sep 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions performance.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,12 @@ For more details, see :doc:`/components/class_loader/cache_class_loader`.
.. index::
single: Performance; Bootstrap files

Use Bootstrap Files
-------------------
Use Bootstrap Files (For < PHP 7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave the title as it was

---------------------------------

.. note::

For PHP 7 and higher versions it is not necessary. It is deprecated for Symfony 4.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we used caution directives for deprecations in the docs. I think we should also provide a little bit of context to this message, like this:

.. caution::

    The performance optimalizations in PHP 7 removed any overhead. As such,
    using the bootstrap file is discouraged when using PHP 7+ and was
    deprecated in Symfony 4.0.


To ensure optimal flexibility and code reuse, Symfony applications leverage
a variety of classes and 3rd party components. But loading all of these classes
Expand Down