Skip to content

Update deployment.rst #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Update deployment.rst #8307

merged 2 commits into from
Jan 2, 2018

Conversation

proArtex
Copy link

Looks like SYMFONY_ENV is no longer exists (flex + framework-bundle). It is now APP_ENV

@wouterj
Copy link
Member

wouterj commented Aug 27, 2017

Hmm, this is a tricky one. When using Symfony 3.3 in the Flex edition, you're 100% correct (ref). However, when using Symfony 3.3 with the Standard Edition (old way) it's still called SYMFONY_ENV (ref).

Let's see what other people think about this. Maybe we should include both and indicate when to use which one (e.g. "run export SYMFONY_ENV=prod (or export APP_ENV=prod if you're using Symfony Flex) before running this command so that"). But I'm not sure if that doesn't make stuff too verbose.

@proArtex
Copy link
Author

Maybe better fork documentation for Flex? I was confused for example when tried to override twig error templates with Flex (no Resources folder exists).

@javiereguiluz
Copy link
Member

Thank you @proArtex.

@javiereguiluz javiereguiluz merged commit 8e072da into symfony:3.3 Jan 2, 2018
javiereguiluz added a commit that referenced this pull request Jan 2, 2018
This PR was merged into the 3.3 branch.

Discussion
----------

Update deployment.rst

Looks like SYMFONY_ENV is no longer exists (flex + framework-bundle). It is now APP_ENV

Commits
-------

8e072da Mentioned APP_ENV for Flex apps
0eee3f1 Update deployment.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants