Skip to content

Add missing comment #8263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing comment #8263

wants to merge 1 commit into from

Conversation

janek109
Copy link
Contributor

@janek109 janek109 commented Aug 6, 2017

No description provided.

@janek109
Copy link
Contributor Author

janek109 commented Aug 6, 2017

This comment will help find where example code should be pasted

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janek109 thanks for your first Symfony Docs contribution! These comments are very important for us, so thanks for adding this missing comment.

I see that you sent this pull request to "master" branch. It's OK, but for the next pull requests, please create them in "the oldest maintained branch that contains the problem". At the moment we maintain 2.7, 2.8, 3.3, 3.4 and master ... so we probably should merge this in 2.7. For this pull request you don't have to worry and you don't have to create another one, because the doc mergers will change the branch while merging ... but for complex pull requests is much more difficult to do it, so it's better to use the right branch from the beginning. Thanks!

@xabbuh xabbuh added this to the 2.7 milestone Aug 7, 2017
@xabbuh
Copy link
Member

xabbuh commented Aug 29, 2017

Thank you @janek109.

xabbuh added a commit that referenced this pull request Aug 29, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #8263).

Discussion
----------

Add missing comment

Commits
-------

7ab8f51 Add missing comment
@xabbuh xabbuh closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants