Fix routing order formats #8154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://symfony.com/doc/current/contributing/documentation/standards.html#formats: > * Routing: Annotations, YAML, XML, PHP Also, I've added `use` statement as `service` option belong to the `Route` annotation class of `FrameworkExtraBundle`.
javiereguiluz
approved these changes
Jul 16, 2017
xabbuh
reviewed
Jul 18, 2017
controller/service.rst
Outdated
| .. code-block:: php-annotations | ||
|
|
||
| # src/AppBundle/Controller/HelloController.php | ||
| // ... |
There was a problem hiding this comment.
I think we should still keep the placeholder comment
xabbuh
reviewed
Jul 18, 2017
controller/service.rst
Outdated
| hello: | ||
| path: /hello | ||
| defaults: { _controller: app.hello_controller:indexAction } | ||
|
|
||
| .. code-block:: php-annotations | ||
|
|
||
| # src/AppBundle/Controller/HelloController.php |
xabbuh
approved these changes
Jul 18, 2017
|
Thank you @yceruto. |
xabbuh
added a commit
that referenced
this pull request
Jul 21, 2017
This PR was squashed before being merged into the 3.3 branch (closes #8154). Discussion ---------- Fix routing order formats http://symfony.com/doc/current/contributing/documentation/standards.html#formats: > * Routing: Annotations, YAML, XML, PHP Also, I've added `use` statement as `service` option belong to the `Route` annotation class of `FrameworkExtraBundle`. Commits ------- 79b2254 Fix routing order formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://symfony.com/doc/current/contributing/documentation/standards.html#formats:
Also, I've added
usestatement asserviceoption belong to theRouteannotation class ofFrameworkExtraBundle.