Added an introductory article for Symfony Flex #8115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Jul 7, 2017
setup/flex.rst
Outdated
| in a Flex-enabled application, Symfony can perform tasks before and after the | ||
| execution of Composer tasks. | ||
|
|
||
| Consider for example the following example: |
There was a problem hiding this comment.
I would remove for example :)
setup/flex.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Recipes are defined in a ``manifest.json`` file and can contain any number of | ||
| other files and directories. For example, this is the full recipe for SwiftmailerBundle: |
There was a problem hiding this comment.
Isn't it just its manifest?
|
@GuilhemN thanks for your review! All is fixed now. |
xabbuh
reviewed
Jul 9, 2017
setup/flex.rst
Outdated
| two public repositories: | ||
|
|
||
| * `Main recipe repository`_, is a curated list of recipes for high quality and | ||
| maintained packages. Symfony Flex only looks for in this repository by default. |
There was a problem hiding this comment.
Are we sure? I thought "look for" was the right verb here ... so "looks for in ..." instead of "looks in ..." In any case, I've made the change you proposed.
xabbuh
reviewed
Jul 9, 2017
setup/flex.rst
Outdated
| $ composer config extra.symfony.allow-contrib true | ||
|
|
||
| Read the `Symfony Recipes documentation`_ to learn everything about how to | ||
| created recipes for your own packages. |
xabbuh
reviewed
Jul 9, 2017
| └── vendor/ | ||
|
|
||
| This means that installing the ``symfony/flex`` dependency in your application | ||
| is not enough. You must also upgrade the directory structure to the one showed |
There was a problem hiding this comment.
Shouldn't we explain the options you can use in your composer.json file to adapt for alternative directory names instead?
There was a problem hiding this comment.
But that's not enough ... if you change the config dir ... Flex won't work because the config dir is correct ... but its contents are not.
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Jul 21, 2017
…iluz) This PR was squashed before being merged into the 3.3 branch (closes #8115). Discussion ---------- Added an introductory article for Symfony Flex We need some official doc about Flex as soon as possible. Later we'll add more articles about it as needed. Thanks! Commits ------- dba7c3d Added an introductory article for Symfony Flex
xabbuh
added a commit
that referenced
this pull request
Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need some official doc about Flex as soon as possible. Later we'll add more articles about it as needed. Thanks!