Skip to content

Fix (sense) typo in ACL documentation #8105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix (sense) typo in ACL documentation #8105

wants to merge 1 commit into from

Conversation

medinae
Copy link

@medinae medinae commented Jul 2, 2017

No description provided.

@weaverryan
Copy link
Member

I have no idea if the change is correct... but it certainly makes sense when you read the next sentence :).

@medinae Are you absolutely sure this change is correct? I know nothing about the ACL component.

@medinae
Copy link
Author

medinae commented Jul 3, 2017 •
edited
Loading

Yep, mostly. But I think it'll better with "If at least one..."
https://github.com/symfony/security-acl/blob/master/Domain/PermissionGrantingStrategy.php

@weaverryan
Copy link
Member

Thanks @medinae! Merged into 2.7

@weaverryan weaverryan closed this Jul 6, 2017
weaverryan added a commit that referenced this pull request Jul 6, 2017
@weaverryan
minor #8105 Fix (sense) typo in ACL documentation (medinae)
8013d78 
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #8105).

Discussion
----------

Fix (sense) typo in ACL documentation

Commits
-------

f59c8ea Fix (sense) typo in ACL documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medinae @weaverryan @javiereguiluz @carsonbot