Skip to content

Use Twig's namespaced paths #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Use Twig's namespaced paths #8088

merged 1 commit into from
Jun 28, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jun 26, 2017

This only solves an inconsistency in this article. Both paths are valid and functional by default in Symfony. But http://symfony.com/doc/2.7/templating/namespaced_paths.html:

As an added bonus, the namespaced syntax is faster.

What do you think about using it everywhere?

This just fix an inconsistency in this article.

Both paths are valid and functional by default in Symfony. But:

> As an added bonus, the namespaced syntax is faster. 

What do you think about using it everywhere?
@weaverryan
Copy link
Member

+1 for using it everywhere. At this point, I imagine we rarely show paths for rendering template bundles (since bundles are more and more rare). And as I understand it, the namespaced paths are recommended going forward.

@xabbuh xabbuh added this to the 2.7 milestone Jun 27, 2017
@weaverryan
Copy link
Member

Thank you @yceruto!

@weaverryan weaverryan merged commit bac2313 into symfony:2.7 Jun 28, 2017
weaverryan added a commit that referenced this pull request Jun 28, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Use Twig's namespaced paths

This only solves an inconsistency in this article. Both paths are valid and functional by default in Symfony. But http://symfony.com/doc/2.7/templating/namespaced_paths.html:

> As an added bonus, the namespaced syntax is faster.

What do you think about using it everywhere?

Commits
-------

bac2313 Use Twig's namespaced paths
@yceruto yceruto deleted the patch-4 branch June 28, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants