[Front-End] Adding note about extracting CSS #8055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jun 18, 2017
xabbuh
reviewed
Jun 18, 2017
| // you can also extract CSS - this will create a 'vendor.css' file | ||
| // this CSS will *not* be included in page1.css or page2.css anymore | ||
| 'bootstrap-sass/assets/stylesheets/_bootstrap.scss' | ||
| ]) |
There was a problem hiding this comment.
well, this is not broken technically, as the semicolon is optional in JS 😄
javiereguiluz
approved these changes
Jun 18, 2017
|
Thank you Ryan. |
xabbuh
added a commit
that referenced
this pull request
Jun 22, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Front-End] Adding note about extracting CSS In Encore, the `createSharedEntry()` can also include CSS. See symfony/webpack-encore#20 Commits ------- 99f9b3a adding note about extracting CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Encore, the
createSharedEntry()can also include CSS.See symfony/webpack-encore#20