Skip to content

resolve_url_loader codeblock does not contain valid javascript #8042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

kasn
Copy link
Contributor

@kasn kasn commented Jun 14, 2017

is
'resolve_url_loader' => false
should be
'resolve_url_loader': false

is 
```'resolve_url_loader' => false```
should be
```'resolve_url_loader': false```
@kasn kasn changed the title resolve_url_loader codeblock did not contain valid javascript resolve_url_loader codeblock does not contain valid javascript Jun 14, 2017
@apfelbox
Copy link
Contributor

You can also omit the quotes on the key.

@weaverryan
Copy link
Member

That's totally my fault :). Thank you Karsten!

@weaverryan weaverryan merged commit 5b19300 into symfony:3.3 Jun 15, 2017
weaverryan added a commit that referenced this pull request Jun 15, 2017
…ipt (kasn)

This PR was merged into the 3.3 branch.

Discussion
----------

resolve_url_loader codeblock does not contain valid javascript

is
```'resolve_url_loader' => false```
should be
```'resolve_url_loader': false```

Commits
-------

5b19300 resolve_url_loader codeblock did not contain valid javascript
@xabbuh xabbuh added this to the 3.3 milestone Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants