Fix some typos #8027
Merged
Fix some typos #8027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jun 12, 2017
yceruto
reviewed
Jun 12, 2017
frontend/encore/simple-example.rst
Outdated
| @@ -128,7 +128,7 @@ Great! Use ``require()`` to import ``jquery`` and ``greet.js``: | |||
| // ./ (or ../) means to look for a local file | |||
| var greet = require('./greet'); | |||
|
|
|||
| $(document).ready(function()) { | |||
| $(document).ready(function() { | |||
| $('h1').html(greet()); | |||
There was a problem hiding this comment.
greet(...) function needs an argument to complete the job https://github.com/symfony/symfony-docs/pull/8032/files#diff-4a37b5376878b65036d1bb0fa49047f7R132
There was a problem hiding this comment.
You are right, thx, I updated the PR.
|
Wow, great catch! Thank you Jacob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.