Skip to content

Anchor to "Configuring the voter" section fixed #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgrajcarek
Copy link

Currently old link from version 2.7 is used and makes page scroll to the top.
This patch fixes it.

Currently old link from version 2.7 is used and makes page scroll to the top.
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgrajcarek nice catch! Thanks for fixing it.

@xabbuh
Copy link
Member

xabbuh commented May 31, 2017

@javiereguiluz The id attribute is properly set to declaring-the-voter-as-a-service above the "Configuring the Voter" headline. Can this be an issue with the website's markup (see also #7921 (comment))?

@@ -186,7 +186,7 @@ would look like this::
}
}

That's it! The voter is done! Next, :ref:`configure it <declaring-the-voter-as-a-service>`.
That's it! The voter is done! Next, :ref:`configure it <configuring-the-voter>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work as there is no configuring-the-voter label in this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see it now.
I will build it localy and update this patch.

@xabbuh
Copy link
Member

xabbuh commented Jul 11, 2017

I am closing here as this seems to have been fixed on the website. Thank you very much anyway for reporting this awkward behaviour @mgrajcarek!

@xabbuh xabbuh closed this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants