add missing choices_as_values options #7949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @HeahDude :) |
HeahDude
approved these changes
Jul 12, 2017
| @@ -490,9 +490,10 @@ sport like this:: | |||
| $positions = null === $sport ? array() : $sport->getAvailablePositions(); | |||
|
|
|||
| $form->add('position', 'entity', array( | |||
| 'class' => 'AppBundle:Position', | |||
| 'class' => 'AppBundle:Position', | |||
There was a problem hiding this comment.
This is not related to your PR but what about dropping this doctrine notation in favor of class constants in the docs? The only advantage it has today IMO is eventually for config files with factory methods (even there I always prefer fqcn though).
There was a problem hiding this comment.
I agree. In #7907 we did that when using the getRepository() method. I will prepare another PR for other places where we use this (like here).
xabbuh
force-pushed
the
choices-as-values
branch
from
04f861a to
899f148
Compare
xabbuh
added a commit
that referenced
this pull request
Jul 12, 2017
This PR was merged into the 2.7 branch. Discussion ---------- add missing choices_as_values options Commits ------- 899f148 add missing choices_as_values options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.