[Form] Fix choice keys and values for custom field types #7940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also fix the PHP code example setting the container parameter? Currently, it defines two parameters |
Choices labels are defined as the keys of the array as of Symfony 3 (see symfony/symfony#14050).
michaelperrin
force-pushed
the
fix/custom-form-type
branch
from
342ad02 to
7cadd32
Compare
|
@xabbuh Done! |
|
Thank you @michaelperrin. |
xabbuh
added a commit
that referenced
this pull request
May 26, 2017
…(michaelperrin) This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7940). Discussion ---------- [Form] Fix choice keys and values for custom field types Choices labels are defined as the keys of the array as of Symfony 3 (see symfony/symfony#14050). I prefered to keep the same parameters for the "Creating your Field Type as a Service" section and call `array_flip` as I think it is clearer to keep the keys as keys (!) for parameters, especially as the labels could contain some spaces. Commits ------- 74b662b Fix choice keys and values for custom field types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choices labels are defined as the keys of the array as of Symfony 3 (see symfony/symfony#14050).
I prefered to keep the same parameters for the "Creating your Field Type as a Service" section and call
array_flipas I think it is clearer to keep the keys as keys (!) for parameters, especially as the labels could contain some spaces.