Skip to content

[Workflow] Incorrect placeholders for leave/enter transitions #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2017
Merged

[Workflow] Incorrect placeholders for leave/enter transitions #7927

merged 1 commit into from
May 26, 2017

Conversation

ssaki
Copy link

@ssaki ssaki commented May 20, 2017

Both leave and enter transitions are related to particular places. The names of most verbose ones incorrectly stated the [transition name] placeholder. The name of the place being leaved/entered is used to generate the event name instead

Both leave and enter transitions are related to particular places. The names of most verbose ones incorrectly stated ``[transition name]``. The name of the place being leaved/entered is used to generate the event name instead
@ssaki ssaki changed the title incorrect placeholdes for leave/enter transitions Workflow: incorrect placeholdes for leave/enter transitions May 20, 2017
@ssaki ssaki changed the title Workflow: incorrect placeholdes for leave/enter transitions Workflow: incorrect placeholders for leave/enter transitions May 20, 2017
@ssaki ssaki changed the title Workflow: incorrect placeholders for leave/enter transitions [Workflow] Incorrect placeholders for leave/enter transitions May 20, 2017
@xabbuh
Copy link
Member

xabbuh commented May 26, 2017

Thank you @ssaki.

@xabbuh xabbuh merged commit 5ea817f into symfony:3.2 May 26, 2017
xabbuh added a commit that referenced this pull request May 26, 2017
…ions (ssaki)

This PR was merged into the 3.2 branch.

Discussion
----------

[Workflow] Incorrect placeholders for leave/enter transitions

Both leave and enter transitions are related to particular places. The names of most verbose ones incorrectly stated the ``[transition name]`` placeholder. The name of the place being leaved/entered is used to generate the event name instead

Commits
-------

5ea817f incorrect placeholdes for leave/enter transitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants