Rework more controllers #7893
Rework more controllers #7893
Conversation
service_container/autowiring.rst
Outdated
| the ``TransformerInterface`` and injects it automatically. Even when using | ||
| interfaces (and you should), building the service graph and refactoring the project | ||
| is easier than with standard definitions. | ||
| The autowiring subsystem detects that the ``Rot13Transformer::class`` service |
There was a problem hiding this comment.
Using the class constant here reads confusing. I would use the FQCN instead.
service_container/autowiring.rst
Outdated
| interfaces (and you should), building the service graph and refactoring the project | ||
| is easier than with standard definitions. | ||
| The autowiring subsystem detects that the ``Rot13Transformer::class`` service | ||
| implements the ``TransformerInterface`` and injects it automatically. Even when |
There was a problem hiding this comment.
Don't we miss the alias for the AppBundle\TransformerInterface?
There was a problem hiding this comment.
Autowiring using types still works but is deprecated (TransformerInterface is detected on Rot13Transformer), do you mind if we reword this more deeply this later in another PR? Or maybe I can simply add a note that it is deprecated?
There was a problem hiding this comment.
We already have the alias a bit further down. Can we maybe just reorder the sections here?
GuilhemN
force-pushed
the
DI33
branch
2 times, most recently
from
a76eb45 to
689c723
Compare
|
I reworked the autowiring article to focus on fqcn aliases. |
|
Thanks @GuilhemN! I had not gotten to these articles yet, so it's perfect! I will review the autowire article a bit further... because it's really important... but Idefinitely wanted to start by merging your changes :). Cheers! |
| AppBundle\Rot13Transformer: ~ | ||
|
|
||
| # the ``AppBundle\Rot13Transformer`` service will be injected when | ||
| # a ``AppBundle\TransformerInterface`` type-hint is detected |
No description provided.