Skip to content

Merge #7861 in 3.2 #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Merge #7861 in 3.2 #7881

wants to merge 18 commits into from

Conversation

GuilhemN
Copy link
Contributor

@GuilhemN GuilhemN commented May 6, 2017

Fix conflicts of #7861 when merged in 3.2.

xabbuh and others added 18 commits April 28, 2017 15:04
* The `url` option was added in version 2.3.10 of the SwiftmailerBundle
  (see symfony/swiftmailer-bundle#118).
* The `timeout` and `source_ip` options are part of SwiftmailerBundle
  since symfony/swiftmailer-bundle#14 which was part of the 2.1.0
  release.
* The `local_domain` option was first included in the 2.4.0 release (see
  symfony/swiftmailer-bundle#141).
This PR was merged into the 2.7 branch.

Discussion
----------

add labels for old headlines

We used to have them in the past (see symfony/demo#547).

Commits
-------

7dbf4c5 add labels for old headlines
…kiwi, javiereguiluz, xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

Backport symfony#7510 for the Symfony 2.7 docs

All the documented options are part of SwiftmailerBundle releases that are compatible with Symfony 2.7.

Commits
-------

1c39991 fix versionadded directives
8eaccef Removed "encryption" and "auth_mode" from the list of %env()% compatible options
3395258 Fixed ... again ... the versionadded directives
3333723 Added the missing "versionadded" directives
0e2853a add mail transport as deprecated
2bd1a22 Minor tweaks
b161bd8 update swiftmailer reference
This PR was merged into the 2.8 branch.

Discussion
----------

[PhpUnitBridge] fix Stopwatch API usage

Commits
-------

fead634 [PhpUnitBridge] fix Stopwatch API usage
…ass (xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[PhpUnitBridge] use namespaced PHPUnit TestCase class

Commits
-------

a22a973 use namespaced PHPUnit TestCase class
…ilhemN)

This PR was merged into the 2.7 branch.

Discussion
----------

Replace calls to setDefinition() by register()

Using `setDefinition`  is very verbose and actually less readable imo, so I think we should push using `ContainerBuilder::register()`.

Commits
-------

879347c Replace calls to setDefinition() by register()
@xabbuh
Copy link
Member

xabbuh commented May 8, 2017

Thanks for the heads up @GuilhemN. But basically I just did not merge up the 2.7 branch yet (so your PR was not part of the other branches). :) I did that now so I have to close your PR.

@xabbuh xabbuh closed this May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants