Property access #7870
Closed
Property access #7870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
May 4, 2017
apfelbox
reviewed
May 4, 2017
components/property_access.rst
Outdated
|
|
||
| public function setLastName($name) | ||
| public function getLastName() | ||
| { | ||
| $this->lastName = $name; |
There was a problem hiding this comment.
You should change this to return $this->lastName; then.
xabbuh
requested changes
May 4, 2017
components/property_access.rst
Outdated
|
|
||
| public function setLastName($name) | ||
| public function getLastName() |
There was a problem hiding this comment.
I don't understand this change. This section is about modifying objects not reading from them.
There was a problem hiding this comment.
I think this looks better.
xabbuh
reviewed
May 5, 2017
components/property_access.rst
Outdated
|
|
||
| public function getChildren() { | ||
| return $this->children; | ||
| } |
There was a problem hiding this comment.
I would move both methods between setLastName() and __set(). And to match the code style of the Symfony code the opening curly brace should be on its own line. However, we can easily make this change while merging your PR.
|
This could be merged 👍 @javiereguiluz |
Simperfit
approved these changes
May 5, 2017
|
@iulyanp thanks a lot for contributing these fixes and congrats on your first Symfony Docs contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I changed the visibility of the
$childrenproperty and use thegetLastNamemethod in order for the example to work correctly.