Skip to content

KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel() #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel() #7816

wants to merge 1 commit into from

Conversation

baruica
Copy link

@baruica baruica commented Apr 18, 2017

No description provided.

xabbuh
xabbuh approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

javiereguiluz
javiereguiluz approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

linaori
linaori approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if static vs self is important here, but the end-result would be the same. This change looks correct to me.

HeahDude
HeahDude approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HeahDude HeahDude added this to the 2.7 milestone Apr 19, 2017
@xabbuh
Copy link
Member

xabbuh commented Apr 27, 2017

Good catch, thanks @baruica.

xabbuh added a commit that referenced this pull request Apr 27, 2017
@xabbuh
minor #7816 KernelTestCase::createKernel() is static, $this->createKe…
4f23382 
…rnel() -> static::createKernel() (baruica)

This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7816).

Discussion
----------

KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()

Commits
-------

b9e931a KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
@xabbuh xabbuh closed this Apr 27, 2017
@baruica baruica deleted the patch-1 branch April 28, 2017 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@linaori linaori linaori approved these changes

@xabbuh xabbuh xabbuh approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@baruica @xabbuh @javiereguiluz @linaori @HeahDude @carsonbot