Requirements: Rewrite note about PHP 5.3.16 #7792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
@alexislefebvre thanks for this! Not only you spotted a hard to find issue but you also provided a perfect fix for it. Thanks!
reference/requirements.rst
Outdated
| @@ -28,8 +28,8 @@ Required | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| Be aware that Symfony has some known limitations when using PHP 5.3.16. | |||
| For more information see the `Requirements section of the README`_. | |||
| Be aware that Symfony 5.3.16 is not suitable to run Symfony, | |||
There was a problem hiding this comment.
It's not Symfony 5.3.16 but PHP 5.3.16 😉
There was a problem hiding this comment.
Thanks for spotting this @viviengaetan! I'm going to fix the typo. 😅
|
Good catch, thanks @alexislefebvre. |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Requirements: Rewrite note about PHP 5.3.16 The `README.md` file was rewritten in this commit: symfony/symfony@c7d30ca#diff-04c6e90faac2675aa89e2176d2eec7d8L19 So the link in _For more information see the Requirements section of the README_ was outdated because the _Requirements_ section was removed. I removed the link and added an explanation that was present in the `README.md` file (see commit above). Commits ------- 5bf065f Requirements: Rewrite note about PHP 5.3.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
README.mdfile was rewritten in this commit:symfony/symfony@c7d30ca#diff-04c6e90faac2675aa89e2176d2eec7d8L19
So the link in For more information see the Requirements section of the README was outdated because the Requirements section was removed.
I removed the link and added an explanation that was present in the
README.mdfile (see commit above).