#7311 choice_value callback argument can be null #7775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for the record. This fixes #7311 |
xabbuh
reviewed
Apr 12, 2017
| @@ -11,6 +11,9 @@ configure the value that will be sent in the API request). | |||
| This can be a callable or a property path. See `choice_label`_ for similar usage. | |||
| If ``null`` is used, an incrementing integer is used as the name. | |||
|
|
|||
| If you are using a callable to populate choice_value, you need to check for the | |||
| case that the value of the field may be null. | |||
There was a problem hiding this comment.
null should be enclosed with two backticks like this:
[...] field may be ``null``.
xabbuh
reviewed
Apr 12, 2017
| @@ -11,6 +11,9 @@ configure the value that will be sent in the API request). | |||
| This can be a callable or a property path. See `choice_label`_ for similar usage. | |||
| If ``null`` is used, an incrementing integer is used as the name. | |||
|
|
|||
| If you are using a callable to populate choice_value, you need to check for the | |||
There was a problem hiding this comment.
choice_value should also be enclosed with double backticks
|
👍 |
javiereguiluz
approved these changes
Apr 14, 2017
There was a problem hiding this comment.
👍 @michaellenahan thanks for your first contribution!
I've made a minor fix (we need two backticks instead of three) but your pull request was perfect otherwise. Thanks.
|
Thank you @michaellenahan. |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
… Lenahan, javiereguiluz) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7775). Discussion ---------- #7311 choice_value callback argument can be null This is my first contribution to Symfony. Thank you @Deltachaos for your help today at the Hackday in Cologne. Commits ------- bf604e5 Fixed a syntax issue da1bbb2 Use backticks c274800 #7311 choice_value callback argument can be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to Symfony. Thank you @Deltachaos for your help today at the Hackday in Cologne.