Skip to content

Fixed code block under "Custom Messages" #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed code block under "Custom Messages" #7762

wants to merge 1 commit into from

Conversation

superhaggis
Copy link
Contributor

Very minor typo correction!

@javiereguiluz
Copy link
Member

@superhaggis it looks like a typo ... but it's not :)

It's a "magic feature" of the format we use to write the docs. If you put :: in the line before some code block, it's highlighted with the default language you configured (PHP in our case).

So, this :: magic avoids us to repeat thousands of times this -->

.. code-block:: php

@javiereguiluz javiereguiluz reopened this Apr 6, 2017
@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 6, 2017 •
edited
Loading

Of course I understood your Pull Request wrong ... not only you know the :: trick, but you correctly fixed it. I'm really sorry 😊 🙏 🙇

javiereguiluz
javiereguiluz approved these changes Apr 6, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

HeahDude
HeahDude approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@xabbuh
Copy link
Member

xabbuh commented Apr 8, 2017

Good catch, thanks @superhaggis.

xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
minor #7762 Fixed code block under "Custom Messages" (superhaggis)
83ca87f 
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7762).

Discussion
----------

Fixed code block under "Custom Messages"

Very minor typo correction!

Commits
-------

32a5c9c Fixed code block under "Custom Messages"
@xabbuh xabbuh closed this Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@superhaggis @javiereguiluz @xabbuh @HeahDude @carsonbot