Skip to content

[Console] Add a note about escaping format tags #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2017
Merged

[Console] Add a note about escaping format tags #7745

merged 2 commits into from
Apr 15, 2017

Conversation

julienfalque
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz approved these changes Apr 15, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for this!

I've removed the last phrase about << because I think that's a bug that Symfony must fix (and it has been reported to the repo).

@xabbuh
Copy link
Member

xabbuh commented Apr 15, 2017

Thank you @julienfalque.

@xabbuh xabbuh merged commit a798c0e into symfony:2.7 Apr 15, 2017
xabbuh added a commit that referenced this pull request Apr 15, 2017
@xabbuh
minor #7745 [Console] Add a note about escaping format tags (julienfa…
bdb3f5c 
…lque, javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Add a note about escaping format tags

Commits
-------

a798c0e Minor reword
3e65874 Add a note about escaping console format tags
@julienfalque julienfalque deleted the console-format-escaping branch April 16, 2017 07:35
@julienfalque
Copy link
Contributor Author

julienfalque commented Jul 6, 2017 •
edited
Loading

Just for reference, the issue regarding << bug is symfony/symfony#18481.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienfalque @xabbuh @javiereguiluz @carsonbot