Skip to content

Update routing.rst #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update routing.rst #7712

wants to merge 2 commits into from

Conversation

atailouloute
Copy link
Contributor

Add missing uses

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but 👍

@@ -206,6 +207,9 @@ to find a route that fits the given request you can also build a URL from
a certain route::

use Symfony\Component\Routing\Generator\UrlGenerator;
use Symfony\Component\Routing\RouteCollection;
use Symfony\Component\Routing\RequestContext;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please keep the alpha order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member

xabbuh commented Apr 1, 2017

Thank you for the many good catches and improvements @atailouloute! To ease the merging of all the small fixes I will combine your PRs in a single PR (see #7737) and merge that one instead.

@xabbuh xabbuh closed this Apr 1, 2017
xabbuh added a commit that referenced this pull request Apr 1, 2017
…ULOUTE)

This PR was squashed before being merged into the 2.7 branch (closes #7737).

Discussion
----------

lots of minor tweaks and fixes

This PR contains all the commits from the following pull requests:

* #7641
* #7652
* #7653
* #7666
* #7667
* #7669
* #7673
* #7674
* #7675
* #7677
* #7680
* #7681
* #7710
* #7711
* #7712
* #7713
* #7714
* #7716
* #7717
* #7718
* #7721
* #7722
* #7736

Commits
-------

3d61281 lots of minor tweaks and fixes
@atailouloute atailouloute deleted the patch-4 branch April 1, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants