Removed any reference to X-Status-Code #7640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems weird to "hide" this feature as it may complicate the path to find a solution anytime some one would need it, what about an explicit warning instead? |
|
In other cases I would agree with you, but remember that Fabien said that nobody should use this "feature" ever. It's like an internal thing to make some things work on Silex. |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
May 11, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Removed any reference to X-Status-Code Fabien says that end users should NEVER use X-Status-Code (see symfony/symfony#22019), so let's remove any reference to it in the docs ... and let's not document the new way to do it (see http://symfony.com/blog/new-in-symfony-3-3-deprecated-x-status-code). Commits ------- 18f8437 Removed any reference to X-Status-Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabien says that end users should NEVER use X-Status-Code (see symfony/symfony#22019), so let's remove any reference to it in the docs ... and let's not document the new way to do it (see http://symfony.com/blog/new-in-symfony-3-3-deprecated-x-status-code).