Skip to content

Fix minor code format #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Fix minor code format #7632

merged 1 commit into from
Mar 17, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Mar 15, 2017

Indeed, show route annotation here (this require SensioFrameworkExtraBundle) is out of Routing component scope, this topic shouldn't be moved to http://symfony.com/doc/3.2/routing.html instead?

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

And you are right ... this probably shouldn't be here because the component doesn't support annotations.

@xabbuh
Copy link
Member

xabbuh commented Mar 17, 2017

Thank you @yceruto.

@xabbuh xabbuh merged commit 634fadd into symfony:3.2 Mar 17, 2017
xabbuh added a commit that referenced this pull request Mar 17, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

Fix minor code format

Indeed, show route annotation here (this require SensioFrameworkExtraBundle) is out of Routing component scope, this topic shouldn't be moved to http://symfony.com/doc/3.2/routing.html instead?

Commits
-------

634fadd Fix minor code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants