Add mention of the SymfonyTestsListener #7624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Mar 14, 2017
There was a problem hiding this comment.
👍
@theofidry thanks for completing the docs about this feature. I did some rewords, but I maintained most of your original contribution. Thanks!
xabbuh
reviewed
Mar 14, 2017
components/phpunit_bridge.rst
Outdated
| @@ -35,6 +35,24 @@ You can install the component in 2 different ways: | |||
|
|
|||
| .. include:: /components/require_autoload.rst.inc | |||
|
|
|||
| If you plan to :ref:`write-assertions-about-deprecations`_ and use the regular | |||
There was a problem hiding this comment.
the trailing underscore must be removed
xabbuh
reviewed
Mar 14, 2017
components/phpunit_bridge.rst
Outdated
| @@ -35,6 +35,24 @@ You can install the component in 2 different ways: | |||
|
|
|||
| .. include:: /components/require_autoload.rst.inc | |||
|
|
|||
| If you plan to :ref:`write-assertions-about-deprecations`_ and use the regular | |||
| PHPUnit script (not the modified PHPUnit script provided by Symfony), then you | |||
| must register a new `test listener`_ called ``SymfonyTestsListener``: | |||
There was a problem hiding this comment.
[...] then you must register [...] -> [...] you have to register [...]?
HeahDude
approved these changes
Mar 14, 2017
|
Thanks very much :) |
|
Thank you @theofidry. |
xabbuh
added a commit
that referenced
this pull request
Mar 17, 2017
…reguiluz) This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #7624). Discussion ---------- Add mention of the SymfonyTestsListener Follow up of symfony/symfony#21982 (comment). /cc @xabbuh Commits ------- 73dccd7 Fixed the issues reported by reviewers ac8121d Removed an extra blank line 865ae6a Reworded the explanation 9263103 Add mention of the SymfonyTestsListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of symfony/symfony#21982 (comment).
/cc @xabbuh