Skip to content

Added a new short article about linting translation files #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added a new short article about linting translation files #7618

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7536.

@xabbuh
Copy link
Member

xabbuh commented Mar 20, 2017 •
edited
Loading

Can we merge this into the 3.2 branch?

@javiereguiluz
Copy link
Member Author

No. It's a 3.3 feature.

@xabbuh
Copy link
Member

xabbuh commented Mar 20, 2017

I'd say let's add a versionadded directive then.

@xabbuh
Copy link
Member

xabbuh commented Mar 20, 2017

And lint:yaml command was already present in Symfony 2.7. Shouldn't we not document that command in older versions of the docs too?

@javiereguiluz
Copy link
Member Author

@xabbuh can we merge this ... and then create a new simple PR based on this (mentioning only the lint:yaml command) and merge it in 2.8?

@xabbuh
Copy link
Member

xabbuh commented Apr 15, 2017

Thank you Javier.

@xabbuh xabbuh added this to the 3.3 milestone Apr 15, 2017
@xabbuh xabbuh closed this in 6a405f4 Apr 15, 2017
xabbuh added a commit that referenced this pull request Apr 15, 2017
@xabbuh
[#7618] add versionadded directive
1ccc224
@javiereguiluz
Copy link
Member Author

Thanks for merging. I'm going to create the new PR now.

@javiereguiluz javiereguiluz mentioned this pull request Apr 15, 2017
Merged
@javiereguiluz
Copy link
Member Author

Done in #7801.

xabbuh added a commit that referenced this pull request May 11, 2017
@xabbuh
minor #7801 Added a new article about linting translation files (javi…
78b3c10 
…ereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Added a new article about linting translation files

This continues #7618 with a simpler article aimed at 2.7 -> 3.2. **Don't merge it up to master** because there's a more complete version of this article.

Commits
-------

bd97f70 Added a new article about linting translation files
@javiereguiluz javiereguiluz deleted the fix_7536 branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Needs Work Translation
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Document the lint:xliff command
4 participants
@javiereguiluz @xabbuh @HeahDude @carsonbot