-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Minor fixes about bundle overridding #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f684bdd
Update inheritance.rst
3433e50
Update installation.rst
2f837d6
Update override.rst
62bfc21
Update prepend_extension.rst
600d302
Update installation.rst
d5cd8d0
Reworded the section about form overridding
javiereguiluz c9a52ae
Added the changes suggested by reviewers
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ Services & Configuration | |
|
||
If you want to modify service definitions of another bundle, you can use a compiler | ||
pass to change the class of the service or to modify method calls. In the following | ||
example, the implementing class for the ``original-service-id`` is changed to | ||
example, the implementing class for the ``original-service-id`` is changed to | ||
``Acme\DemoBundle\YourService``:: | ||
|
||
// src/Acme/DemoBundle/DependencyInjection/Compiler/OverrideServiceCompilerPass.php | ||
|
@@ -72,17 +72,8 @@ associations. Learn more about this feature and its limitations in | |
Forms | ||
----- | ||
|
||
In order to override a form type, it has to be registered as a service (meaning | ||
it is tagged as ``form.type``). You can then override it as you would override any | ||
service as explained in `Services & Configuration`_. This, of course, will only | ||
work if the type is referred to by its alias rather than being instantiated, | ||
e.g.:: | ||
|
||
$builder->add('name', 'custom_type'); | ||
|
||
rather than:: | ||
|
||
$builder->add('name', new CustomType()); | ||
Existing form types can be modified defining "form type extensions". | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I propose: |
||
For more information, see :doc:`/form/create_form_type_extension`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
.. _override-validation: | ||
|
||
|
@@ -93,7 +84,7 @@ Symfony loads all validation configuration files from every bundle and | |
combines them into one validation metadata tree. This means you are able to | ||
add new constraints to a property, but you cannot override them. | ||
|
||
To override this, the 3rd party bundle needs to have configuration for | ||
To overcome this, the 3rd party bundle needs to have configuration for | ||
:doc:`validation groups </validation/groups>`. For instance, the FOSUserBundle | ||
has this configuration. To create your own validation, add the constraints | ||
to a new validation group: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been confusion in the past about which resources we refer to here. I think we should make more clear that this note does not apply when we talk about templates as the overriding of them works no matter if you use the bundle syntax or the native Twig namespace syntax (I know that the syntax is not exactly the same as what we use to refer to other resources, but that's not so obvious).