Skip to content

Added a new section "Extracting Translation Contents and Updating Cat… #7477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #4061.

I propose to mention Symfony Translation Bundle, created by @Nyholm, instead of the semi-abandoned JMSTranslationBundle. @Nyholm is actively supporting his bundle and soon he's going to propose integrating some of its best features into the core Symfony bundle.

@javiereguiluz
Copy link
Member Author

Please, someone review this proposal. Thanks!

translation.rst Outdated

If you need to extract translation strings from other sources, such as
controllers, forms and flash messages, consider using the more advanced
`TranslationBundle`_ third-party bundle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] third-party TranslationBundle.

translation.rst Outdated

The most time-consuming task when translating an application is to extract all
the template contents to be translated and to keep all the translation files in
sync. Symfony includes a command called ``translation:update`` that helps you in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] helps you with these tasks.

translation.rst Outdated
these tasks.

The "safe mode" of this command uses the ``--dump-messages`` option to output
in the command console the strings to be translated:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] to output the strings to be translated:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this - let's just show the commands below

@xabbuh xabbuh added this to the 2.7 milestone Jul 9, 2017
translation.rst Outdated
these tasks.

The "safe mode" of this command uses the ``--dump-messages`` option to output
in the command console the strings to be translated:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this - let's just show the commands below

translation.rst Outdated

# updates the English translation file to add the missing strings
# found on AppBundle templates
$ ./app/console translation:update --force en AppBundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of think we should only show --force and mention in a comment (e.g. "without --force, the missing strings are only rendered to the screen")

@weaverryan
Copy link
Member

weaverryan commented Nov 2, 2017

Status: Needs Work

javiereguiluz added a commit that referenced this pull request Jan 11, 2018
…Updating Cat… (javiereguiluz)

This PR was squashed before being merged into the 2.7 branch (closes #7477).

Discussion
----------

Added a new section "Extracting Translation Contents and Updating Cat…

This fixes #4061.

I propose to mention [Symfony Translation Bundle](https://github.com/php-translation/symfony-bundle), created by @Nyholm, instead of the semi-abandoned JMSTranslationBundle. @Nyholm is actively supporting his bundle and soon he's going to propose integrating some of its best features into the core Symfony bundle.

Commits
-------

74e82e0 Added a new section "Extracting Translation Contents and Updating Cat…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants