Skip to content

Update standards.rst #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2017
Merged

Update standards.rst #7461

merged 2 commits into from
May 12, 2017

Conversation

VolCh
Copy link
Contributor

@VolCh VolCh commented Feb 11, 2017

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@roman-1983 roman-1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -218,7 +218,8 @@ Service Naming Conventions

* The DI alias of the bundle is the first group (e.g. ``fos_user``);

* Use lowercase letters for service and parameter names;
* Use lowercase letters for service and parameter names (except when referring
to environment variables with the ``%env(VARIABLE_NAME)%`` syntax);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should note that they should not begin with an underscore as it is to be deprecated.

@xabbuh
Copy link
Member

xabbuh commented May 12, 2017

Thank you @VolCh.

@xabbuh xabbuh merged commit 2867b34 into symfony:3.2 May 12, 2017
xabbuh added a commit that referenced this pull request May 12, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

Update standards.rst

According http://symfony.com/blog/new-in-symfony-3-2-runtime-environment-variables

Commits
-------

2867b34 Minor reword
68ae76f Update standards.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants