Skip to content

[HttpFoundation][Fix] Component version #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

20uf
Copy link
Contributor

@20uf 20uf commented Jan 27, 2017

Hello,

Small PR to correct the version of the component HttpFoundation in the composer.json.

Regards,

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, ^3.0 will also install 3.2. The proposed change would be mandatory if we use some feature that it's only available in 3.2 version. Otherwise, the minimum version can be as low as we want.

But on the other hand, this change wouldn't hurt us either. So I don't know what to say about this proposal :)

@20uf
Copy link
Contributor Author

20uf commented Jan 30, 2017

All right!

I would say to answer that, that it's subtle and that your best be explicit.

@xabbuh
Copy link
Member

xabbuh commented Jan 30, 2017

The drawback is that we would have to make this change on every branch (in theory, we would then also have to change the constraint to ^3.1 on the 3.1 branch). I am not sure if we really want to do that.

@20uf
Copy link
Contributor Author

20uf commented Jan 30, 2017

In this case would not it be more judicious to leave only composer command:

composer require symfony/http-foundation

There is no such notion of composer.json on other docs, eg:

@20uf
Copy link
Contributor Author

20uf commented Feb 5, 2017

Hello @xabbuh @javiereguiluz.

A solution for this PR? What do we do?

@javiereguiluz
Copy link
Member

I agree with the last comment. We could remove the composer.json contents example entirely.

Before

To use this component, add it as a dependency of the project:

.. code-block:: terminal

    $ composer require symfony/http-foundation

Running this command will also automatically download the Symfony
HttpFoundation component and install it under the ``vendor/`` directory.
A ``composer.json`` and a ``composer.lock`` file will be generated as well,
containing the new requirement:

.. code-block:: json

    {
        "require": {
            "symfony/http-foundation": "^3.0"
        }
    }

The code block shows the content of the ``composer.json`` file (the actual
version may vary).

After

To use this component, add it as a dependency of the project:

.. code-block:: terminal

    $ composer require symfony/http-foundation

Running this command will also automatically download the Symfony
HttpFoundation component and install it under the ``vendor/`` directory.
A ``composer.json`` and a ``composer.lock`` file will be generated as well,
containing the new requirement.

@20uf
Copy link
Contributor Author

20uf commented Feb 13, 2017

Hello @xabbuh @javiereguiluz.

Are the latest changes right for you? We are ISO with other documentation.

Regards

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Feb 28, 2017

Thank you @20uf.

xabbuh added a commit that referenced this pull request Feb 28, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7423).

Discussion
----------

[HttpFoundation][Fix] Component version

Hello,

Small PR to correct the version of the component HttpFoundation in the composer.json.

Regards,

Commits
-------

d60f64d [HttpFoundation][Fix] Component version
@xabbuh xabbuh closed this Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants