-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[HttpFoundation][Fix] Component version #7423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, ^3.0 will also install 3.2. The proposed change would be mandatory if we use some feature that it's only available in 3.2 version. Otherwise, the minimum version can be as low as we want.
But on the other hand, this change wouldn't hurt us either. So I don't know what to say about this proposal :)
All right! I would say to answer that, that it's subtle and that your best be explicit. |
The drawback is that we would have to make this change on every branch (in theory, we would then also have to change the constraint to |
In this case would not it be more judicious to leave only composer command:
There is no such notion of composer.json on other docs, eg: |
Hello @xabbuh @javiereguiluz. A solution for this PR? What do we do? |
I agree with the last comment. We could remove the BeforeTo use this component, add it as a dependency of the project:
.. code-block:: terminal
$ composer require symfony/http-foundation
Running this command will also automatically download the Symfony
HttpFoundation component and install it under the ``vendor/`` directory.
A ``composer.json`` and a ``composer.lock`` file will be generated as well,
containing the new requirement:
.. code-block:: json
{
"require": {
"symfony/http-foundation": "^3.0"
}
}
The code block shows the content of the ``composer.json`` file (the actual
version may vary). AfterTo use this component, add it as a dependency of the project:
.. code-block:: terminal
$ composer require symfony/http-foundation
Running this command will also automatically download the Symfony
HttpFoundation component and install it under the ``vendor/`` directory.
A ``composer.json`` and a ``composer.lock`` file will be generated as well,
containing the new requirement. |
Hello @xabbuh @javiereguiluz. Are the latest changes right for you? We are ISO with other documentation. Regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Status: reviewed
Thank you @20uf. |
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7423). Discussion ---------- [HttpFoundation][Fix] Component version Hello, Small PR to correct the version of the component HttpFoundation in the composer.json. Regards, Commits ------- d60f64d [HttpFoundation][Fix] Component version
Hello,
Small PR to correct the version of the component HttpFoundation in the composer.json.
Regards,