Fix Platform.sh Build #7402
Closed
Fix Platform.sh Build #7402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrawley
changed the title
|
@javiereguiluz Can you obtain the build log for this PR on platform.sh? |
|
robfrawley
force-pushed
the
bug-fix-platformsh-build
branch
from
fb0dcd1 to
21fbfef
Compare
|
@javiereguiluz There isn't a way to publicly see the build log, is there? |
|
@robfrawley I'm afraid is not. This is the new log: |
|
This looks like it might be a |
|
@damz I'm not sure how to do that. Maybe @weaverryan or @Crell can help us here. Thanks! |
|
@damz Thanks for that, it is definitely a If anyone wants to help, I'll add them to the test project so they can directly see the platform.sh build output and try committing fixes. Send me your e-mail if you want access and intend to assist. I'll give your suggestion a try @damz; thanks! |
|
Working with platform.sh support. I'll keep you guys updated when/if they happen on a resolution. |
robfrawley
force-pushed
the
bug-fix-platformsh-build
branch
from
21fbfef to
9fe53a5
Compare
|
@javiereguiluz Fixed thanks to @damz and platform.sh support answers. I don't think we should pin everything, this is just my opinion, though. Platform.sh support crew turned out to be very helpful. |
robfrawley
force-pushed
the
bug-fix-platformsh-build
branch
2 times, most recently
from
843b677 to
24107fe
Compare
|
@damz Not pinning everything shouldn't cause issues moving forward because of the use of virtualenv, right? Or am I wrong here? |
|
@robfrawley Not pinning everything is bound to cause troubles similar to this one in the future. In my testing, I've seen that this project doesn't currently build with You would not do a PHP project without a |
|
Newest additional commit updates |
robfrawley
force-pushed
the
bug-fix-platformsh-build
branch
from
d36a9cd to
4940b3e
Compare
robfrawley
commented
Jan 24, 2017
| @@ -6,9 +6,9 @@ sudo: false | |||
| cache: | |||
| directories: [$HOME/.cache/pip] | |||
|
|
|||
| install: pip install sphinx~=1.3.0 git+https://github.com/fabpot/sphinx-php.git | |||
| install: pip install -r _build/.requirements.txt sphinx==1.3.0 | |||
There was a problem hiding this comment.
@javiereguiluz The requirement of 1.3.0 for TravisCI is due to the following warning (turned into error) that halts the build due to sphinx-php overwriting code-block using sphinx versions greater than 1.3:
Warning, treated as error:
WARNING: while setting up extension sensio.sphinx.codeblock: directive 'code-block' is already registered, it will be overridden
We may need to re-think the use of -nW opts for Travis runs, as this is incompatible with newer versions of Sphinx (which throw a warning on overridden directives), and this will become a problem at some point (as we begin to reply on newer features and need to run newer versions).
There was a problem hiding this comment.
Thanks! I've turned this comment into a proper issue (#7422) to not lose track of it.
robfrawley
force-pushed
the
bug-fix-platformsh-build
branch
from
4940b3e to
8ead251
Compare
|
Let's close this because, fortunately, the build errors were fixed in another PR. Thanks! |
This was referenced Jun 9, 2017
weaverryan
added a commit
that referenced
this pull request
Jun 13, 2017
…frawley) This PR was merged into the 2.7 branch. Discussion ---------- Fix and align travis and platform build environments This pull request fixes the `platform.sh` deploy and aligns the `platform.sh` and `travis-ci.org` build to use the same version constraints and environments. Per @xabbuh in #8009 (comment) this PR has been made against the `2.7` branch. Original implementation pulled from #8010 and #8009. Changes include: - Update the `pip` version requirements pulled in by [_build/.requirements.txt](https://github.com/robfrawley/symfony-docs/blob/feature-align-travis-and-platform-build/_build/.requirements.txt) to latest releases, except for `sphinx` which must be downgraded to `1.3` until we find a solution for `sphinx-php` (which there doesn't seem to be much interest in fixing: #7402 (comment), #7422, fabpot/sphinx-php#33). - Use the same package management and constraint requirements for both `platform.sh` and `travis-ci.org` by having both utilize the `_build/.requirements.txt` file when calling `pip`. - Use the same documentation build command to compile the documentation HTML (`make`) while still calling `sphinx` with "strict mode" (or, more accurately, "turn warnings into errors mode") for `travis-ci.org`. - On `platform.sh`, since the `vitrualenv` folder is at the documentation root, remove all `rst` files contained within it (pulled in from the `pip` packages) via a `find` command, so as to ensure the build doesn't pull them in (they would never appear in the output as they don't exist in the doctree, but if they contain errors or other inconsistencies, this could cause the build to fail while reading in their sources). - `find .virtualenv -type f -name "*.rst" -delete` Commits ------- 764bc37 align travis and platform build environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7265 (comment) and #7265 (comment) for additional info.