Fix missing key for time-sensitive tests #7391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Thank you @z38. |
xabbuh
added a commit
that referenced
this pull request
Jan 24, 2017
This PR was merged into the 2.8 branch. Discussion ---------- Fix missing key for time-sensitive tests The Symfony test listener [prints a warning](https://github.com/symfony/symfony/blob/4491eb64633f1945537e8a6a07adbb3ef5c1f802/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php#L66) when numeric keys are used to configure mocked namespaces. As the specification of multiple namespaces might be a bit intuitive (I can't add multiple `<element key="time-sensitive">`), maybe the following example would be better: ```xml <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"> <arguments> <array> <element key="time-sensitive"> <array> <element><string>Symfony\Component\HttpFoundation</string></element> </array> </element> </array> </arguments> </listener> ``` Commits ------- 1d1c58b Fix missing key for time-sensitive tests
|
@z38 I have merged your changes as is. As I don't think people will often register more than one listener with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony test listener prints a warning when numeric keys are used to configure mocked namespaces.
As the specification of multiple namespaces might be a bit intuitive (I can't add multiple
<element key="time-sensitive">), maybe the following example would be better: