Skip to content

Possible fix for the broken link for cache #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Conversation

chasen
Copy link
Contributor

@chasen chasen commented Jan 18, 2017

No description provided.

@@ -1489,6 +1489,7 @@ throw
Throw PHP errors as ``\ErrorException`` instances. The parameter
``debug.error_handler.throw_at`` controls the threshold.

.. _reference-cache:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you have to add a blank line after the label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw yes, sorry i missed that.

@xabbuh
Copy link
Member

xabbuh commented Jan 18, 2017

@chasen Thanks for noticing this and making this fix. I think adding the missing blank line will fully solve the issue.

@xabbuh
Copy link
Member

xabbuh commented Jan 24, 2017

Good catch, thanks @chasen.

@xabbuh xabbuh merged commit 0d61095 into symfony:3.2 Jan 24, 2017
xabbuh added a commit that referenced this pull request Jan 24, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

Possible fix for the broken link for cache

Commits
-------

0d61095 add missing blank line
90c3338 Possible fix for the broken link for cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants