Added a note about case-insensitiveness of service ids #7374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jan 17, 2017
| @@ -154,6 +154,12 @@ later how you can configure a service that has multiple instances in the | |||
| ``get()`` method to locate and retrieve the ``app.mailer`` service from | |||
| the service container. | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
Should this be a caution instead?
|
👍 Status: Reviewed |
|
Thank you Javier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7367. I propose to add just a small note because my guess it that the case-insensitive behavior is unused by 99.99% of developers and most of them are even unaware of it.