Deprecated ContainerAwareEventDispatcher

[javiereguiluz]

This fixes #7340.

[xabbuh]

Instead of documenting the deprecation I would update the example to show code that will be working with Symfony 4.0 too.

[javiereguiluz]

@xabbuh you mean the example in components/event_dispatcher.rst?

[xabbuh]

Yes, maybe move it to its own article and then also add a link in the existing chapter to it.

[javiereguiluz]

I wonder ... why not remove that example entirely? It doesn't explain nothing special ... just how to define services with tags, right?

[xabbuh]

Fine for me too. I am just afraid that users with older Symfony versions might be confused (sure, in an ideal world they wouldn't read the 3.2 docs, but you know what's going on).

[javiereguiluz]

I've checked other articles and I have a question.

In service_container/tags.rst we say that if you add this code, the Twig extension will be automatically registered:

$definition = new Definition(AppExtension::class);
$definition->setPublic(false);
$definition->addTag('twig.extension');
$container->setDefinition('app.twig_extension', $definition);

But that's not true, right? You need to add some special compiler pass to manage the twig.extension tag.

That's why the example in event_dispatcher.rst mentions the RegisterListenersPass().

---

So I propose the following:

• Remove the event_dispatcher.rst example entirely
• Improve service_container/tags.rst to better explain what you must do to enable the service tags

[xabbuh]

Well, service_container/tags.rst addresses users of the full-stack framework so we can safely assume that the compiler pass is registered. The event_dispatcher.rst however is located in the components section where we cannot make this assumption.

[xabbuh]

I would remove the "compiler pass" part here. This reads a bit weird.

[xabbuh]

You must also register a compiler pass call RegisterListenersPass in the container builder

[xabbuh]

👍

Status: Reviewed

[xabbuh]

Thank you @javiereguiluz.