-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Reworded the user checker aliases explanation #7291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I agree that the new explanation is more clear than the existing one. However, I wonder if we need it at all. Is this information really necessary? |
@xabbuh I think I agree. I don't understand why Symfony does this and I don't know why a developer should know this. But I've never used a user checker, so I could be missing something important. |
@javiereguiluz It's useful to simplify some internal code of the SecurityBundle, but I don't think that's anything we need to document. At least, I would not add the note here as it may lead to more confusion than necessary. If we wanted to document this, I would vote for creating a dedicated article that explains how to hook into the SecurityBundle. |
@xabbuh I've removed it :) |
👍 Status: Reviewed |
@javiereguiluz Was it intended to target the |
It was intended because at the beginning of the article one can read:
|
Thank you Javier. |
The original explanation looked confusing to me. Let's see if others agree.