Skip to content

Reworded the user checker aliases explanation #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

The original explanation looked confusing to me. Let's see if others agree.

@xabbuh
Copy link
Member

xabbuh commented Dec 27, 2016

I agree that the new explanation is more clear than the existing one. However, I wonder if we need it at all. Is this information really necessary?

@javiereguiluz
Copy link
Member Author

@xabbuh I think I agree. I don't understand why Symfony does this and I don't know why a developer should know this. But I've never used a user checker, so I could be missing something important.

@xabbuh
Copy link
Member

xabbuh commented Dec 27, 2016

@javiereguiluz It's useful to simplify some internal code of the SecurityBundle, but I don't think that's anything we need to document. At least, I would not add the note here as it may lead to more confusion than necessary. If we wanted to document this, I would vote for creating a dedicated article that explains how to hook into the SecurityBundle.

@javiereguiluz
Copy link
Member Author

@xabbuh I've removed it :)

@xabbuh
Copy link
Member

xabbuh commented Dec 27, 2016

👍

Status: Reviewed

@xabbuh
Copy link
Member

xabbuh commented Dec 27, 2016

@javiereguiluz Was it intended to target the 2.8 branch instead of 2.7?

@javiereguiluz
Copy link
Member Author

It was intended because at the beginning of the article one can read:

.. versionadded:: 2.8
    The ability to configure a custom user checker per firewall was introduced
    in Symfony 2.8.

@xabbuh
Copy link
Member

xabbuh commented Jan 10, 2017

Thank you Javier.

xabbuh added a commit that referenced this pull request Jan 10, 2017
…luz)

This PR was squashed before being merged into the 2.8 branch (closes #7291).

Discussion
----------

Reworded the user checker aliases explanation

The original explanation looked confusing to me. Let's see if others agree.

Commits
-------

de34b77 Reworded the user checker aliases explanation
@xabbuh xabbuh closed this Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants