Fix sample sqlite database path in doctrine config #7263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Can you also create another PR for Symfony 2.7 where this points to |
xabbuh
added a commit
that referenced
this pull request
Dec 15, 2016
…sr, javiereguiluz) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7267). Discussion ---------- Fix sample sqlite database path in doctrine config Port of #7263 for 2.7 Commits ------- 048579b %kernel.root_dir%/app/data/data.sqlite -> %kernel.root_dir%/data/data.sqlite e1115e5 Fix sample sqlite database path in doctrine config
|
Thank you @chalasr. |
xabbuh
added a commit
that referenced
this pull request
Dec 15, 2016
This PR was merged into the 3.1 branch. Discussion ---------- Fix sample sqlite database path in doctrine config I think sqlite databases should be stored in `var/` as it is storage. About the `%kernel.data_dir%` removed here, I never heard about such a parameter in the core, either I missed it or it's very old. Please tell me if we should first change it on lower branches, replacing it by `%kernel.root_dir%/app/data/data.sqlite`. See also symfony/symfony-standard#1032 on the same topic Commits ------- 9126fdf Fix sample sqlite database path in doctrine config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think sqlite databases should be stored in
var/as it is storage.About the
%kernel.data_dir%removed here, I never heard about such a parameter in the core, either I missed it or it's very old.Please tell me if we should first change it on lower branches, replacing it by
%kernel.root_dir%/app/data/data.sqlite.See also symfony/symfony-standard#1032 on the same topic