Skip to content

Replace undefined argument with intended string argument #7222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Replace undefined argument with intended string argument #7222

merged 1 commit into from
Dec 12, 2016

Conversation

gskema
Copy link
Contributor

@gskema gskema commented Dec 4, 2016

Since the comment mentions app.user_config_manager, I assume it was meant to be used as an argument here.

@ogizanagi
Copy link
Contributor

Good catch 👍

Status: Reviewed

@xabbuh
Copy link
Member

xabbuh commented Dec 4, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2016

Good catch, thanks @gskema.

@xabbuh xabbuh merged commit 7345297 into symfony:2.7 Dec 12, 2016
xabbuh added a commit that referenced this pull request Dec 12, 2016
…(gskema)

This PR was merged into the 2.7 branch.

Discussion
----------

Replace undefined argument with intended string argument

Since the comment mentions `app.user_config_manager`, I assume it was meant to be used as an argument here.

Commits
-------

7345297 Replace undefined argument with intended string argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants