Changing field type in MySQL example #7221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems inconsistent that the MySQL table as the sess_id as VARBINARY, when the PostgeSQL and Microsoft SQL server use VARCHAR (which makes more sense to me)
|
Makes sense to me. If VARBINARY is only used to prevent collation issues (which can be avoided with proper setup aswell) we should keep it consistent and use VARCHAR. |
javiereguiluz
approved these changes
Dec 23, 2016
|
Thank you @steveWinter. |
xabbuh
added a commit
that referenced
this pull request
Dec 25, 2016
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7221). Discussion ---------- Changing field type in MySQL example It seems inconsistent that the MySQL table as the sess_id as VARBINARY, when the PostgeSQL and Microsoft SQL server use VARCHAR (which makes more sense to me) Commits ------- e772465 Changing field type in MySQL example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems inconsistent that the MySQL table as the sess_id as VARBINARY, when the PostgeSQL and Microsoft SQL server use VARCHAR (which makes more sense to me)