Skip to content

fix build command for Linux #7216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix build command for Linux #7216

wants to merge 1 commit into from

Conversation

snoek09
Copy link

@snoek09 snoek09 commented Dec 3, 2016

This was spotted by @sawmurai during the SymfonyCon Berlin hackday.

Can anyone check if the command for Windows is correct?

@xabbuh
Copy link
Member

xabbuh commented Dec 3, 2016

@wouterj Can you check that for Windows?

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I can verify this fix in macOS. Given that this is completely wrong at the moment, we can merge it as it is and later fix the Windows command if needed.

@xabbuh
Copy link
Member

xabbuh commented Dec 25, 2016

Thank you @snoek09.

xabbuh added a commit that referenced this pull request Dec 25, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #7216).

Discussion
----------

fix build command for Linux

This was spotted by @sawmurai during the SymfonyCon Berlin hackday.

Can anyone check if the command for Windows is correct?

Commits
-------

7107b96 fix build command for Linux
@xabbuh xabbuh closed this Dec 25, 2016
@snoek09 snoek09 deleted the fix-build-command branch March 7, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants