Updated "Authentication System with Guard" Page #7215
Conversation
|
|
||
| **createAuthenticatedToken(UserInterface $user, string $providerKey)** | ||
| If you are implementing the :class:`Symfony\\Component\\Security\\Guard\\GuardAuthenticatorInterface` | ||
| Method instead of extending the :class:`Symfony\\Component\\Security\\Guard\\AbstractGuardAuthenticator`, |
There was a problem hiding this comment.
we could add "class" before the comma
| Method instead of extending the :class:`Symfony\\Component\\Security\\Guard\\AbstractGuardAuthenticator`, | ||
| you have to implement this method. This method will be called | ||
| after a successful authentication to create and return the token | ||
| for the user, which was supplied as the first argument. |
|
Thanks for the suggestions, i accepted them |
|
|
||
| **createAuthenticatedToken(UserInterface $user, string $providerKey)** | ||
| If you are implementing the :class:`Symfony\\Component\\Security\\Guard\\GuardAuthenticatorInterface` | ||
| instead of extending the :class:`Symfony\\Component\\Security\\Guard\\AbstractGuardAuthenticator`, |
There was a problem hiding this comment.
I think we should also add the word "class" after the class name.
|
👍 Looks perfect to me! Thanks for you work @powerdan! Status: Reviewed |
|
I just added the class word there. I also thinks its an good idea |
|
|
||
| **createAuthenticatedToken(UserInterface $user, string $providerKey)** | ||
| If you are implementing the :class:`Symfony\\Component\\Security\\Guard\\GuardAuthenticatorInterface` | ||
| class instead of extending the :class:`Symfony\\Component\\Security\\Guard\\AbstractGuardAuthenticator` |
There was a problem hiding this comment.
@powerdan Sorry about that but class that you added here should be reverted. GuardAuthenticatorInterface is an interface, but not a class. Though as Interface is already part of the name we shouldn't add the word "interface" instead of "class". We should only keep the one after AbstractGuardAuthenticator.
There was a problem hiding this comment.
Youre absolutely right. It seems that i am kind of tired after that week.... (in berlin since monday)
| **createAuthenticatedToken(UserInterface $user, string $providerKey)** | ||
| If you are implementing the :class:`Symfony\\Component\\Security\\Guard\\GuardAuthenticatorInterface` | ||
| instead of extending the :class:`Symfony\\Component\\Security\\Guard\\AbstractGuardAuthenticator` | ||
| class, you have to implement this method. This method will be called |
There was a problem hiding this comment.
I don't like the ... this method. This method ... repetition in this line. How could we reword it?
There was a problem hiding this comment.
Changing it to ... this method. It will be called... seems pretty simple, but im not really happy with it. What does you people think?
There was a problem hiding this comment.
... this method. It will be called... sounds completely valid to me.
|
Thank you @powerdan. |
…, Daniel Werner) This PR was merged into the 2.8 branch. Discussion ---------- Updated "Authentication System with Guard" Page Added the (optional) createAuthenticatedToken() Method and dcoumented it. Also added the braces to the no-argument Method supportsRememberMe. Also removed the `` Operators in the FAQ section because the bacticks seems not to be resolved in a title on symfony.com Commits ------- d17b180 Accepted Suggestions cb3abf3 Accepted suggestions in the guard documentation b2f20f4 Accepted suggestions in the guard documentation 33c0d35 Accepted suggestions in the guard documentation f8e201f Update guard_authentication.rst
Added the (optional) createAuthenticatedToken() Method and dcoumented it.
Also added the braces to the no-argument Method supportsRememberMe.
Also removed the `` Operators in the FAQ section because the bacticks seems not to be resolved in a title on symfony.com