adding the namespace for ArrayInput #7192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the documentation a little cleaner, easier to copy
chalasr
suggested changes
Nov 28, 2016
| @@ -10,6 +10,9 @@ generating Doctrine2 proxies, dumping Assetic assets, ...). | |||
|
|
|||
| Calling a command from another one is straightforward:: | |||
|
|
|||
| use Symfony\Component\Console\Input\ArrayInput | |||
| @@ -10,6 +10,9 @@ generating Doctrine2 proxies, dumping Assetic assets, ...). | |||
|
|
|||
| Calling a command from another one is straightforward:: | |||
|
|
|||
| use Symfony\Component\Console\Input\ArrayInput | |||
| // ... | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
There was a problem hiding this comment.
If we do it for ArrayInput, shouldn't we do it for these too?
There was a problem hiding this comment.
I didn't because they are standard to all commands, I included ArrayInput as its the first time (in my experience) the concept is introduced.
|
👍 I think it makes sense to document it this way. All other classes should indeed be known at this point. Status: Reviewed |
|
Thank you @nodefortytwo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the documentation a little cleaner, easier to copy