Clarify the mappings that require no method prefix. #7131
Conversation
| ("get", "is" or "has") is omitted in the mapping. This allows you to move | ||
| the constraint to a property with the same name later (or vice versa) | ||
| without changing your validation logic. | ||
| ("get", "is" or "has") is omitted in the mappings for YAML, XML and PHP. |
There was a problem hiding this comment.
I would change this a bit to "[...] is omitted in the mappings for the YAML, XML and PHP format."
There was a problem hiding this comment.
Thanks, will do. Do you want a separate "change" commit or happy for it to be merged into the existing single one?
There was a problem hiding this comment.
You can do what fits your workflow best. :) We have a nice tool that allows use to squash commits during merging PRs.
There was a problem hiding this comment.
It doesn't matter because we use a tool that squashes everything automatically, so your pull request will be merged as a single commit :)
There was a problem hiding this comment.
Great! I'll push a revision then and let your magic tool do the job for me :-)
|
Thank you @richsage. |
…sage) This PR was squashed before being merged into the 2.7 branch (closes #7131). Discussion ---------- Clarify the mappings that require no method prefix. On the Validation page, there is a section about "getter" constraints. In the note it wasn't clear about where the prefix should be dropped, given that the example annotation constraints doesn't include any method specifics. This PR clarifies that. Commits ------- e82c918 Clarify the mappings that require no method prefix.
On the Validation page, there is a section about "getter" constraints. In the note it wasn't clear about where the prefix should be dropped, given that the example annotation constraints doesn't include any method specifics. This PR clarifies that.