Skip to content

Update guard_authentication.rst #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update guard_authentication.rst #7067

wants to merge 4 commits into from

Conversation

andreybolonin
Copy link
Contributor

Fixed const usage, array syntax

@javiereguiluz
Copy link
Member

@andreybolonin I'm afraid that we can't use the short array notation because it was decided to keep using the traditional notation, like Symfony does in its source code.

@andreybolonin
Copy link
Contributor Author

I'm afraid that we can't use the short array notation because it was decided to keep using the traditional notation, like Symfony does in its source code.

Ok, and what about use Response class constants instead of '404' and etc?

@javiereguiluz
Copy link
Member

Personally I like the response constants a lot. Let's ask other doc maintainers (@xabbuh and @wouterj) if they agree too.

@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2016

I am fine with using the constants for HTTP status codes. I guess that's more readable when you're not too familiar with all the possible codes.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 22, 2016

Thank you @andreybolonin.

xabbuh added a commit that referenced this pull request Nov 22, 2016
…iluz)

This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes #7067).

Discussion
----------

Update guard_authentication.rst

Fixed const usage, array syntax

Commits
-------

ff729c5 Reverted a change made by mistake
2831204 Added the missing "use" import for the Response class
0582c7c Reverted the short array notation
9c1541e Update guard_authentication.rst
@xabbuh xabbuh closed this Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants