Add Nginx configuration to environment variables #7044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Oct 7, 2016
| @@ -40,13 +40,41 @@ the following ``VirtualHost`` configuration: | |||
| </Directory> | |||
| </VirtualHost> | |||
|
|
|||
| For Nginx web servers, the environment variables can be set with `fastcgi_param`_ | |||
There was a problem hiding this comment.
[...] with the fastcgi_param [...]
xabbuh
reviewed
Oct 7, 2016
| @@ -40,13 +40,41 @@ the following ``VirtualHost`` configuration: | |||
| </Directory> | |||
| </VirtualHost> | |||
|
|
|||
| For Nginx web servers, the environment variables can be set with `fastcgi_param`_ | |||
| directive. For example in the configuration file where the ``fastcgi_params`` | |||
There was a problem hiding this comment.
By the way, is the part about the included fastcgi_params file mandatory? I mean is it important that this file is imported?
There was a problem hiding this comment.
The fastcgi_params file includes other server and execution environment information defined with fastcgi_param such as:
DOCUMENT_ROOT, SERVER_ADDR etc. It is not essential to be on this place. More because of a convenience and according to other examples as well. The custom defined environment variables would be set also without this file in PHP later on but the PHP $_SERVER would not be filled with other info.
|
👍 LGTM |
|
I don't use Nginx, but this looks 👍 to me. Thanks @peterkokot. |
|
Thank you @peterkokot. |
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2016
* 2.7: [#7044] minor tweak Add Nginx configuration to environment variables Fix typo in doctrine.rst (to manage) Changed RFC links from drafts to proposed standarts Remove a dead link to the PR header Minor improvements for the contribution guide use single quotes for YAML strings Fix incorrect callback validation example Fix a typo in the serializer doc Fix 404 error link for American English Oxford Dictionary Use strict comparison
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2016
* 2.8: [#7044] minor tweak Add Nginx configuration to environment variables Fix typo in doctrine.rst (to manage) Changed RFC links from drafts to proposed standarts Remove a dead link to the PR header Minor improvements for the contribution guide use single quotes for YAML strings Fix incorrect callback validation example Fix a typo in the serializer doc Fix 404 error link for American English Oxford Dictionary Use strict comparison
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2016
* 3.1: [#7044] minor tweak Add Nginx configuration to environment variables Update the Apache Router article to deprecate it entirely Fix typo in doctrine.rst (to manage) Changed RFC links from drafts to proposed standarts Remove a dead link to the PR header Minor improvements for the contribution guide use single quotes for YAML strings Fix incorrect callback validation example Fix a typo in the serializer doc Fix 404 error link for American English Oxford Dictionary Use strict comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variables example in the configuration chapter currently includes only configuration for Apache web server. This patch adds also Nginx with the
fastcgi_paramdirective.Thank you for considering merging it. In case there needs to be some additional rewording or changes done, let me know.