Skip to content

Add empty parentheses to method names #7017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Conversation

bocharsky-bw
Copy link
Contributor

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Sep 30, 2016

👍

Status: Reviewed

@javiereguiluz
Copy link
Member

👍

@javiereguiluz
Copy link
Member

A missing one in security/api_key_authentication.rst:

This will provide a method ``onAuthenticationFailure`` which

@javiereguiluz
Copy link
Member

Another missing one in best_practices/security.rst:

matches the value returned by the ``getAuthorEmail`` method

@javiereguiluz
Copy link
Member

Another one in bundles/extension.rst:

your load method looks like

@javiereguiluz
Copy link
Member

Another one in components/config/definition.rst:

The ``canBeDisabled`` method looks

I won't add more comments here ... but you get the idea that there are a lot of other cases 😁

@bocharsky-bw
Copy link
Contributor Author

Well, regular expressions rock!

@javiereguiluz Let me know if I missed something... ;)

@@ -685,7 +685,7 @@ method to access the list of errors. It returns a

$errorsAsArray = iterator_to_array($form->getErrors());

This is useful, for example, if you want to use PHP's ``array_`` function
This is useful, for example, if you want to use PHP's ``array_()`` function
Copy link
Member

@javiereguiluz javiereguiluz Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array_() -> array_*() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@xabbuh
Copy link
Member

xabbuh commented Nov 22, 2016

Thank you @bocharsky-bw.

@xabbuh xabbuh merged commit 3cfaf38 into symfony:2.7 Nov 22, 2016
xabbuh added a commit that referenced this pull request Nov 22, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

Add empty parentheses to method names

Commits
-------

3cfaf38 Add empty parentheses to method names
@bocharsky-bw bocharsky-bw deleted the patch-4 branch November 22, 2016 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants