[Routing] Add a note for invokable controllers #6951
Conversation
chalasr
changed the title
| .. tip:: | ||
|
|
||
| For referring to the ``__invoke`` method of a controller, no need for | ||
| passing the method name, just use its fully-qualified namespace. |
There was a problem hiding this comment.
I think we should reword this a bit:
To refer to an action that is implemented as the
__invoke()method of a controller class, you do not have to pass the method name, but can just use the fully qualified class name.
And we should then add an example for it imo.
There was a problem hiding this comment.
Maybe also move it to its own headline?
There was a problem hiding this comment.
👍 For reword and the example, I made the changes.
About the visibility, IMHO we should stay consistent with the controllers as a service note above, don't you think it's enough as is?
chalasr
force-pushed
the
invokable_controllers
branch
from
1a30691 to
e0fa4ad
Compare
chalasr
force-pushed
the
invokable_controllers
branch
from
e0fa4ad to
0b046b3
Compare
|
In the note below it's referencing to Controller as a Service. When using Controller as a Service, you simply refer to the service id: |
|
@iltar The note redirects to a dedicated section which already document that https://github.com/symfony/symfony-docs/blob/master/controller/service.rst#referring-to-the-service |
|
Thank you @chalasr. |
This PR was merged into the 2.7 branch. Discussion ---------- [Routing] Add a note for invokable controllers Since this feature can help to avoid defining controllers as services or writing `Controller::__invoke` when it's not needed, I think we should document it. Commits ------- 0b046b3 [Routing] Add a note for refering invokable controllers
Since this feature can help to avoid defining controllers as services or writing
Controller::__invokewhen it's not needed, I think we should document it.