Skip to content

[Form] Finally document Data Mappers #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 181 additions & 0 deletions form/data_mappers.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,181 @@
.. index::
single: Form; Data mappers

How to Use Data Mappers
=======================

This comment was marked as resolved.


Data mappers are the layer between your form data (e.g. the bound object) and
the form. They are responsible for mapping the data to the fields and back. The
built-in data mapper uses the :doc:`PropertyAccess component </components/property_access>`
and will fit most cases. However, you can create your own data mapper that
could, for example, pass data to immutable objects via their constructor.

The Difference between Data Transformers and Mappers
----------------------------------------------------

It is important to know the difference between
:doc:`data transformers </form/data_transformers>` and mappers.

* **Data transformers** change the representation of a value. E.g. from
``"2016-08-12"`` to a ``DateTime`` instance;
* **Data mappers** map data (e.g. an object) to form fields, and vice versa.

Changing a ``YYYY-mm-dd`` string value to a ``DateTime`` instance is done by a
data transformer. Mapping this ``DateTime`` instance to a property on your
object (e.g. by calling a setter or some other method) is done by a data
mapper.

Creating a Data Mapper
----------------------

Suppose that you want to save a set of colors to the database. For this, you're
using an immutable color object::

// src/AppBundle/Colors/Color.php
namespace AppBundle\Colors;

class Color
{
private $red;
private $green;
private $blue;

public function __construct($red, $green, $blue)
{
$this->red = $red;
$this->green = $green;
$this->blue = $blue;
}

public function getRed()
{
return $this->red;
}

public function getGreen()
{
return $this->green;
}

public function getBlue()
{
return $this->blue;
}
}

The form type should be allowed to edit a color. But because you've decided to
make the ``Color`` object immutable, a new color object has to be created each time
one of the values is changed.

.. tip::

If you're using a mutable object with constructor arguments, instead of
using a data mapper, you should configure the ``empty_data`` with a closure
as described in
:ref:`How to Configure empty Data for a Form Class <forms-empty-data-closure>`.

The red, green and blue form fields have to be mapped to the constructor
arguments and the ``Color`` instance has to be mapped to red, green and blue
form fields. Recognize a familiar pattern? It's time for a data mapper!

.. code-block:: php

// src/AppBundle/Form/DataMapper/ColorMapper.php
namespace AppBundle\Form\DataMapper;

use AppBundle\Colors\Color;
use Symfony\Component\Form\DataMapperInterface;
use Symfony\Component\Form\Exception\UnexpectedTypeException;

class ColorMapper implements DataMapperInterface
{
public function mapDataToForms($data, $forms)
{
// there is no data yet, a new color will be created
if (null === $data) {
return;
}

// invalid data type, this message will not be shown to the user (see below)
if (!$data instanceof Color) {
throw new UnexpectedTypeException($data, Color::class);
}

$forms = iterator_to_array($forms);

// set form field values
$forms['red']->setData($data->getRed());
$forms['green']->setData($data->getGreen());
$forms['blue']->setData($data->getBlue());
}

public function mapFormsToData($forms, &$data)
{
$forms = iterator_to_array($forms);

// get form field values
$red = $forms['red']->getData();
$green = $forms['green']->getData();
$blue = $forms['blue']->getData();

// as data is passed by reference, overriding it will change it in
// the form object as well
$data = new Color($red, $green, $blue);
}
}

.. caution::

The data passed to the mapper is *not yet validated*. This means that your
objects should allow being created in an invalid state in order to produce
user-friendly errors in the form.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to explain what you have to do when your object's constructor raises exceptions in case some assertions are not fulfilled (@webmozart didn't address that concern in his blog post neither and that's the reason I am not sure if we should really cover it here or rather advise to use DTOs instead).

Copy link
Contributor

@HeahDude HeahDude Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also why scalar type hints in PHP7 cause some troubles. The form maps submitted data before validating its underlying data.

What we have to do in such case, is to validate data before mapping it ourselves :( I think he talked about it in his last conferences (suggestion to use custom data mappers for PHP 7).

Not sure what's the best way to approach this problem though, a "caution" note might be enough after all.

Copy link
Contributor

@ogizanagi ogizanagi Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the underlying fields use proper form types (like an IntegerType for an object property typehinted int in the constructor), the field itself will throw a TransformationFailedException which will be rendered as an error on the view on this particular field.
Important part is that the field won't be mapped back and (IIRC) keeps original value. Thus, in most cases, I think it won't cause any issue with scalar typehints.

See ogizanagi/symfony@4f76c21 and FormTypeTest.php#L745-L752
(it doesn't use a scalar typehint, but a \DomainException is thrown if Money::amount isn't numeric. The case is similar).

Appart from the above point, catching the error and throwing a TranformationFailedException ourself is a good safe guard (I recommend to use the invalid_message option in order to render a less cryptic error message, but that's limited).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogizanagi Your test does not cover what I'm talking about. When clear missing is true or if you submit an empty string, the returned model data will be null and the call of the setter will end with a php error because of the type hint which does not trigger a casting of null even if strict_type is false although it does cast a string to an int.

Copy link
Contributor

@ogizanagi ogizanagi Sep 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeahDude: Right, it won't cover everything anyway. However, regarding what you're talking about, maybe it would be interesting to make the transformers use the required option (or a new one if necessary for BC) in order to disallow the transformation and throw a TransformationFailedException('A number is required') in case the value is an empty string.


Using the Mapper
----------------

You're ready to use the data mapper for the ``ColorType`` form. Use the
:method:`Symfony\\Component\\Form\\FormBuilderInterface::setDataMapper`
method to configure the data mapper::

// src/AppBundle/Form/ColorType.php
namespace AppBundle\Form;

use AppBundle\Form\DataMapper\ColorMapper;

// ...
class ColorType extends AbstractType
{
public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder
->add('red', 'integer')
->add('green', 'integer')
->add('blue', 'integer')

->setDataMapper(new ColorMapper())
;
}

public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
// when creating a new color, the initial data should be null
'empty_data' => null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default unless data_class is set or if some data prepopulates the form

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaics, the default it '' and not null. I think I might added this because of that

));
}
}

Cool! When using the ``ColorType`` form, the custom ``ColorMapper`` will create
the ``Color`` object now.

.. caution::

When a form field has the ``inherit_data`` option set, data mappers won't
be applied to that field.

.. tip::

You can also implement ``DataMapperInterface`` in the ``ColorType`` and add
the ``mapDataToForms()`` and ``mapFormsToData()`` in the form type directly
to avoid creating a new class. You'll then have to call
``$builder->setDataMapper($this)``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example should do it like that since this does not makes sense to reuse it elsewhere, and the note could then say that you can handle it in a specific class to easily share it between types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started doing this, but I rejected it. If we directly implement it like that, the structure of the article gets less clear (now it's create DTO, create mapper, use mapper).

8 changes: 7 additions & 1 deletion form/data_transformers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,15 @@ to render the form, and then back into a ``DateTime`` object on submit.

.. caution::

When a form field has the ``inherit_data`` option set, Data Transformers
When a form field has the ``inherit_data`` option set, data transformers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that one?

won't be applied to that field.

.. seealso::

If, instead of transforming the representation of a value, you need to map
values to a form field and back, you should use a data mapper. Check out
:doc:`/form/data_mappers`.

.. _simple-example-sanitizing-html-on-user-input:

Simple Example: Transforming String Tags from User Input to an Array
Expand Down
2 changes: 2 additions & 0 deletions form/use_empty_data.rst
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ some dependency into the ``BlogType`` when we instantiate it, then use that
to instantiate the ``Blog`` class. The point is, you can set ``empty_data``
to the exact "new" object that you want to use.

.. _forms-empty-data-closure:

Option 2: Provide a Closure
---------------------------

Expand Down