Add a class specificity for SplFileInfo text #6867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rendler-denis
commented
Aug 10, 2016
rendler-denis
commented
- update text to differentiate between PHP's SplFileInfo and Symfony's SplFileInfo
- update text to differentiate between PHP's SplFileInfo and Symfony's SplFileInfo
| @@ -41,7 +41,7 @@ directories:: | |||
| } | |||
|
|
|||
| The ``$file`` is an instance of :class:`Symfony\\Component\\Finder\\SplFileInfo` | |||
| which extends :phpclass:`SplFileInfo` to provide methods to work with relative | |||
| which extends PHP's own :phpclass:`\SplFileInfo` to provide methods to work with relative | |||
There was a problem hiding this comment.
Issue resolved :)
I added it just to provide a FQN context.
Remove additional backslash
|
👍 status: reviewed |
|
I like it! Thanks Denis! |
weaverryan
added a commit
that referenced
this pull request
Aug 16, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6867). Discussion ---------- Add a class specificity for SplFileInfo text - update text to differentiate between PHP's SplFileInfo and Symfony's SplFileInfo Commits ------- 923ce50 Remove additional backslash f6a9464 Add a class specificity for SplFileInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.